Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Handwired] Support for Adafruit lemon keypad #16395

Merged
merged 2 commits into from
Feb 27, 2022
Merged

[Handwired] Support for Adafruit lemon keypad #16395

merged 2 commits into from
Feb 27, 2022

Conversation

qcoral
Copy link

@qcoral qcoral commented Feb 18, 2022 •
edited
Loading

Description

QMK + Via support for a handwired Lemon-themed keypad, designed by Adafruit. Modified for a pro micro.
https://learn.adafruit.com/qtpy-lemon-mechanical-keypad-macropad

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 18, 2022
@drashna
Copy link
Member

drashna commented Feb 21, 2022

This contains changes from other PRs, which need to be reverted.

@drashna drashna requested a review from a team February 21, 2022 07:11
fauxpark
fauxpark requested changes Feb 21, 2022
View reviewed changes
keyboards/handwired/lemonpad/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/lemonpad/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/lemonpad/config.h Outdated Show resolved Hide resolved
@github-actions github-actions bot added the core label Feb 22, 2022
@qcoral
Copy link
Author

qcoral commented Feb 22, 2022

Reverted changes from other PRs and added suggested changes. Thank you all for your time.

@drashna
Copy link
Member

drashna commented Feb 22, 2022

Other changes are still there, it looks like. Rebasing may work better to fix the issues.

@github-actions github-actions bot removed the core label Feb 22, 2022
fauxpark
fauxpark requested changes Feb 22, 2022
View reviewed changes
keyboards/handwired/lemonpad/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested review from drashna and fauxpark February 22, 2022 21:35
@drashna drashna merged commit d94b5d0 into qmk:master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qcoral @drashna @fauxpark @zvecr