Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Uthol #16393

Merged
merged 20 commits into from
Mar 8, 2022
Merged

[Keyboard] Uthol #16393

merged 20 commits into from
Mar 8, 2022

Conversation

Uthol
Copy link

@Uthol Uthol commented Feb 18, 2022

Description

Updates to Uthol keyboard as per previous PR suggestions and fixed a few little things.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Feb 21, 2022
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
keyboards/handwired/uthol/config.h Outdated Show resolved Hide resolved
keyboards/handwired/uthol/config.h Outdated Show resolved Hide resolved
keyboards/handwired/uthol/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/uthol/rev3/config.h Show resolved Hide resolved
@Uthol Uthol requested a review from drashna February 23, 2022 06:15
@drashna drashna requested a review from a team February 27, 2022 01:16
fauxpark
fauxpark requested changes Feb 27, 2022
View reviewed changes
keyboards/handwired/uthol/rev1/rules.mk Show resolved Hide resolved
keyboards/handwired/uthol/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/uthol/rev2/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/uthol/rev2/rules.mk Show resolved Hide resolved
keyboards/handwired/uthol/rev3/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/uthol/rev3/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/uthol/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/uthol/readme.md Outdated Show resolved Hide resolved
Uthol
Uthol commented Feb 28, 2022
View reviewed changes
Copy link
Author

@Uthol Uthol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the requested changes.

@Uthol Uthol requested a review from fauxpark February 28, 2022 06:45
@drashna drashna requested a review from a team March 7, 2022 03:34
fauxpark
fauxpark requested changes Mar 7, 2022
View reviewed changes
keyboards/handwired/uthol/rev2/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/uthol/rev3/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/uthol/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/uthol/readme.md Outdated Show resolved Hide resolved
Uthol
Uthol commented Mar 7, 2022
View reviewed changes
Copy link
Author

@Uthol Uthol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made

@drashna drashna merged commit b2fdb07 into qmk:master Mar 8, 2022
@drashna
Copy link
Member

drashna commented Mar 8, 2022

Thanks!!

0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@Uthol @drashna
@fauxpark @zykrah
[Keyboard] Uthol (qmk#16393)
f4ce915 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uthol @drashna @fauxpark