Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for large Mouse Reports #16371

Merged
merged 20 commits into from
Jun 9, 2022
Merged

Add support for large Mouse Reports #16371

merged 20 commits into from
Jun 9, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Feb 16, 2022

Description

While looking at tmk stuff, I noticed that that they added support for 16-bit X and Y reports for mouse reports.

This expands the report to allow for int16_t to be used for the x and y axises, as well as boot mouse reports.

I suspect that the mouse boot protocol requires that the endpoint not be shared, but ... I'm not sure about that.

Types of Changes

  • Core
  • New feature
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team February 16, 2022 07:26
@github-actions github-actions bot added the core label Feb 16, 2022
sigprof
sigprof requested changes Feb 16, 2022
View reviewed changes
tmk_core/protocol/usb_descriptor.c Outdated Show resolved Hide resolved
@drashna drashna requested review from a team and daskygit February 16, 2022 18:20
daskygit
daskygit reviewed Feb 20, 2022
View reviewed changes
quantum/pointing_device_drivers.c
@@ -165,11 +162,26 @@ const pointing_device_driver_t pointing_device_driver = {
// clang-format on

#elif defined(POINTING_DEVICE_DRIVER_pimoroni_trackball)

mouse_xy_report_t pimoroni_trackball_adapt_values(clamp_range_t* offset) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intended to move this from pimoroni_trackball.c?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Wanted to move all the hid clamping stuff into the drivers file, as it's more appropriate there, I think.

@daskygit
Copy link
Member

Using the extended reports with the pimoroni trackball, does seem to produce a better feel to the device. I guess the reason for not making this the default is the extra firmware space required?

@drashna
Copy link
Member Author

drashna commented Feb 23, 2022

Using the extended reports with the pimoroni trackball, does seem to produce a better feel to the device. I guess the reason for not making this the default is the extra firmware space required?

That may be because it's not hitting the 127 limit, and generates a more natural feel.

And yeah, also, not everything may support it, so opt in is better than opt out, until there are enough people using it to verify it's not an issue.

@drashna drashna force-pushed the pointing/large_reports branch from 74f88e8 to e995e03 Compare February 26, 2022 03:25
@foureight84 foureight84 mentioned this pull request Mar 5, 2022
Closed
@drashna drashna mentioned this pull request Mar 9, 2022
Closed
7 tasks
@drashna drashna requested review from sigprof and a team March 14, 2022 03:34
@drashna drashna force-pushed the pointing/large_reports branch from e995e03 to 1c7754f Compare March 16, 2022 01:00
@pashashocky
Copy link

+1 tested - makes pimoroni trackball significantly more accurate and smooth.

@drashna drashna requested a review from daskygit May 3, 2022 06:11
@daskygit
Copy link
Member

daskygit commented May 3, 2022

It's probably worth adding this define to the documentation?

@drashna drashna force-pushed the pointing/large_reports branch from 1c7754f to 07e0285 Compare May 3, 2022 17:04
@drashna
Copy link
Member Author

drashna commented May 3, 2022

It's probably worth adding this define to the documentation?

I had forgotten, actually. Added in 07e0285

daskygit
daskygit approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@daskygit daskygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weak approval as I can't comment much on the usb descriptor changes other than it works.

tzarc
tzarc requested changes May 14, 2022
View reviewed changes
drivers/sensors/pimoroni_trackball.h Outdated Show resolved Hide resolved
quantum/pointing_device.c Outdated Show resolved Hide resolved
quantum/pointing_device.c Outdated Show resolved Hide resolved
@tzarc tzarc requested a review from fauxpark May 15, 2022 06:32
fauxpark
fauxpark requested changes May 15, 2022
View reviewed changes
tmk_core/protocol/usb_descriptor.c Outdated Show resolved Hide resolved
tmk_core/protocol/usb_descriptor.c Outdated Show resolved Hide resolved
tmk_core/protocol/vusb/vusb.c Outdated Show resolved Hide resolved
@tzarc tzarc requested a review from fauxpark May 15, 2022 21:42
drashna and others added 19 commits June 8, 2022 14:35
@drashna
Start work on adding 16bit reports to mouse reports
a179051
@drashna
remember that report struct needs to match endpoint struct too
117eba7
@drashna
liiiiiiint
aa3a580
@drashna @sigprof
Update tmk_core/protocol/usb_descriptor.c
f595ad1 
Co-authored-by: Sergey Vlasov <[email protected]>
@drashna
Add typedefs for x and y sizes
fdde5be
@drashna
Clean up descriptors
c41b8ec
@drashna
Add vbus support for extended desriptors?
b31a3d4
@drashna
Lintying'
f6bfb1c
@drashna
pimoroni support and cleanup
0423f2e
@drashna
make functions more consistent
515afe7
@drashna
Linting
71b2dcc
@drashna
use proper descriptor info for vusb
dea21e7
@drashna
Add docs
a519f58
@drashna
Remove redundancy
78f90ed
@drashna
Add suggestions from review
c0d3684
@drashna
Appease the linter
02d79f8
@drashna @fauxpark
Apply suggestions from code review
34ab83e 
Co-authored-by: Ryan <[email protected]>
@drashna @fauxpark
Update tmk_core/protocol/usb_descriptor.c
110d215 
Co-authored-by: Ryan <[email protected]>
@drashna
Change name
36598c6
@drashna drashna force-pushed the pointing/large_reports branch from e7cbf1b to d8a055c Compare June 8, 2022 21:36
@drashna drashna force-pushed the pointing/large_reports branch from d8a055c to caebf93 Compare June 8, 2022 21:37
@drashna drashna merged commit 0ab51ee into qmk:develop Jun 9, 2022
@drashna drashna deleted the pointing/large_reports branch June 9, 2022 01:39
@waffle87 waffle87 mentioned this pull request Jun 9, 2022
Merged
8 tasks
@dkao dkao mentioned this pull request Jun 23, 2022
Merged
14 tasks
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@drashna @sigprof
@fauxpark @zykrah
Add support for large Mouse Reports (qmk#16371)
4f810de 
Co-authored-by: Sergey Vlasov <[email protected]>
Co-authored-by: Ryan <[email protected]>
@drashna drashna mentioned this pull request Aug 27, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit approved these changes

@tzarc tzarc tzarc approved these changes

@sigprof sigprof Awaiting requested review from sigprof

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
core documentation keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@drashna @daskygit @pashashocky @sigprof @tzarc @fauxpark