Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Wasdat Code custom matrix to SN74x138 driver #16257

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Feb 7, 2022

Description

A followup to #16217.

This board is similar to the Wasdat, but the column setup is a little different. According to the schematic, D4 is connected to one of the 74HC138's enable pins, and all output pins are connected to a column (whereas on the Wasdat the IC is always enabled, and only 7 of the 8 outputs are connected, with address 0 being set when a non-demux column is selected).

@evyd13 if you still have one of these, would you mind testing it, or pointing someone else who has one here?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team February 7, 2022 03:38
@evyd13
Copy link
Contributor

evyd13 commented Feb 7, 2022

@evyd13 if you still have one of these, would you mind testing it, or pointing someone else who has one here?

Mine is with a friend of mine. If yours works it should be good to go 👍

@fauxpark
Copy link
Member Author

fauxpark commented Feb 7, 2022

I don't have a Code, just a normal WASD V2 with a Wasdat. I'm only able to verify the latter, although the matrix.c implementation is very nearly identical, but it would be good to get proper confirmation.

@fauxpark fauxpark merged commit 07ca35d into qmk:develop Mar 7, 2022
@fauxpark fauxpark deleted the wasdat-code-demux branch March 7, 2022 23:02
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Mar 23, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants