Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MS Sculpt Mobile refactor #16038

Merged
merged 1 commit into from
Mar 20, 2022
Merged

MS Sculpt Mobile refactor #16038

merged 1 commit into from
Mar 20, 2022

Conversation

fauxpark
Copy link
Member

Description

Removing the use of the ASTAR define in favour of revision folders for the Teensy 2++ and Pololu A-Star configs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 25, 2022 13:42
@milestogo
Copy link
Contributor

patch should not be needed if we can finish up #14461

@fauxpark
Copy link
Member Author

There are some changes here that aren't in that PR.

@fauxpark fauxpark mentioned this pull request Mar 10, 2022
Closed
12 tasks
@fauxpark fauxpark merged commit cfe2893 into qmk:develop Mar 20, 2022
@fauxpark fauxpark deleted the ms-sculpt-refactor branch March 20, 2022 04:19
milestogo added a commit to milestogo/qmk_firmware that referenced this pull request Jul 3, 2022
@milestogo
finish rework to match qmk#16038
7933e76
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@fauxpark @zykrah
MS Sculpt Mobile refactor (qmk#16038)
450b7c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @milestogo @drashna @tzarc