Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right side ws2812 leds having two indices #15985

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

daskygit
Copy link
Member

Description

I'm assuming this is a bug but I'm unsure if targeting master is the correct option as it may break users keymaps depending on which index they used to address the right side leds.

So the example below shows the issue, where index 12 and 30 currently refers to the same physical led on the right side.

// config.h
RGB_MATRIX_SPLIT { 18, 18 }

// keymap.c
void rgb_matrix_indicators_user(void) {
    rgb_matrix_set_color(30, 0, 0, 255); // blue
    rgb_matrix_set_color(12, 255, 255, 255); // white
}

This currently results in the led being white but after applying this PR it's blue as you'd expect.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 22, 2022
@drashna drashna requested a review from a team January 22, 2022 06:17
@drashna drashna added the bug label Jan 22, 2022
@daskygit daskygit changed the base branch from master to develop January 31, 2022 18:32
@zvecr zvecr merged commit 00cc646 into qmk:develop Feb 11, 2022
@daskygit daskygit deleted the fix_split_rgb_m_led_idx branch March 13, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants