Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adafruit_ble: support chibios #15947

Closed
wants to merge 1 commit into from

Conversation

Gigahawk
Copy link

@Gigahawk Gigahawk commented Jan 20, 2022

Enable ADAFRUIT_BLE on ChibiOS.

Description

Tested on a Bluefruit LE SPI with an STM32F405, it seems to mostly work.
It seems to work fine I pair my phone over Bluetooth, if I power cycle the board, then I can reconnect as normal but no keystrokes get sent even after OUT_BT is pressed.
If I unpair and then pair again it works until the next power cycle.
Disconnecting from my phone without turning off the board works fine.

EDIT: Apparently the latest Bluefruit firmware is just buggy, a cursory test of 0.6.7 as suggested from adafruit/Adafruit_BluefruitLE_Firmware#27 seems to work fine, although it causes one of the QMK init commands to fail with > result: ERROR.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 20, 2022
@Gigahawk Gigahawk force-pushed the adafruit_ble_chibios branch from 3913942 to 6fff436 Compare January 20, 2022 08:45
@fauxpark
Copy link
Member

I'm already working on this.

@Gigahawk Gigahawk changed the title [WIP] adafruit_ble: support chibios adafruit_ble: support chibios Jan 20, 2022
@drashna drashna requested review from sigprof, fauxpark and a team January 22, 2022 05:26
@1Conan 1Conan mentioned this pull request Feb 2, 2022
14 tasks
@Gigahawk Gigahawk force-pushed the adafruit_ble_chibios branch from 6fff436 to 1ccd547 Compare March 1, 2022 03:07
@nickwitha-k
Copy link

@Gigahawk Just found an issue, while working on setting this up. This 16127 looks to be merged and renames all of the Adafruit functions, vars, etc. Not sure if there's additional consideration required but thought I'd mention as I'm working on testing this now.

@Gigahawk Gigahawk force-pushed the adafruit_ble_chibios branch from 1ccd547 to 35c45e8 Compare March 1, 2022 09:18
@Gigahawk
Copy link
Author

Gigahawk commented Mar 1, 2022

everything has been renamed, should work fine now

@stale
Copy link

stale bot commented Apr 16, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@Gigahawk Gigahawk force-pushed the adafruit_ble_chibios branch from 35c45e8 to b274d3d Compare May 5, 2022 06:51
@stale stale bot removed the awaiting changes label May 5, 2022
@Gigahawk Gigahawk force-pushed the adafruit_ble_chibios branch from b274d3d to 0781239 Compare May 5, 2022 06:54
@Gigahawk
Copy link
Author

Gigahawk commented May 5, 2022

@fauxpark is there anything actually preventing this from being merged?

I know the bluetooth refactor is coming eventually, but it seems like that's going to take a while.
I don't see why this can't be merged in the meantime given how small of a change it is.

@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 13, 2022
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Aug 13, 2022
@rockybulwinkle
Copy link

@Gigahawk I tried your changes but get an undefined file, "outputselect.h". Can you provide any insight? I'm using the teensy 4.1.

@rockybulwinkle
Copy link

Also, @fauxpark, is your work being tracked by an issue and/or on a feature branch? I cannot find it.

@Gigahawk Gigahawk deleted the adafruit_ble_chibios branch August 14, 2022 03:56
@Gigahawk Gigahawk restored the adafruit_ble_chibios branch December 20, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants