Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combo TAP_CODE_DELAY and clear_weak_mods #15866

Merged
merged 3 commits into from
Jan 29, 2022

Conversation

sevanteri
Copy link
Contributor

Description

TAP_CODE_DELAY: Some software (e.g. some games) don't like key press and release events too close to each other, so a delay is needed after dumping the key buffer in combo processing.

clear_weak_mods: Before, weak mods from combos could leak to the next key press if pressed too fast.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Some software don't like key press and release events too close to each
other, so a delay is needed after dumping the key buffer in combo
processing.
Before, weak mods from combos could leak to the next key press if
pressed too fast.
@github-actions github-actions bot added the core label Jan 13, 2022
@sevanteri
Copy link
Contributor Author

Why does "some software" have to suck so bad... I hate having TAP_CODE_DELAY already...

@drashna drashna requested a review from a team January 13, 2022 18:14
@sevanteri
Copy link
Contributor Author

Needs some work still. If a mod-tap or similar is part of a combo, the delay is applied twice after releasing the key (once in combo processing, once in the tapping monstrosity process_action)

@drashna drashna self-requested a review January 14, 2022 02:55
@tzarc tzarc requested a review from a team January 16, 2022 19:41
@drashna
Copy link
Member

drashna commented Jan 29, 2022

Needs some work still. If a mod-tap or similar is part of a combo, the delay is applied twice after releasing the key (once in combo processing, once in the tapping monstrosity process_action)

Is this ready to go, as is?

@sevanteri
Copy link
Contributor Author

Yeah, should be good to go, haven't had problems with it.

@drashna drashna merged commit d700447 into qmk:develop Jan 29, 2022
uvera pushed a commit to uvera/qmk_firmware that referenced this pull request Dec 14, 2022
uvera pushed a commit to uvera/qmk_firmware that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants