Adjust tap_code16 to account for TAP_HOLD_CAPS_DELAY #15635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unlike
tap_code
,tap_code16
does not apply the caps lock delay (TAP_HOLD_CAPS_DELAY
), when the key code is caps lock. As a result, in most operating systems, the caps lock key will not register since it's cycled too quickly. This change mirrors the structure oftap_code
, but using the same functionwait_ms
, as is currently intap_code16
, to add this delay in, if the key code is caps lock.This is consistent with existing documentation which says that the 16 version of the function behaves "similar" to the non 16 version.
Types of Changes
Checklist