Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tap_code16 to account for TAP_HOLD_CAPS_DELAY #15635

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

Ga68
Copy link

@Ga68 Ga68 commented Dec 29, 2021

Description

Unlike tap_code, tap_code16 does not apply the caps lock delay (TAP_HOLD_CAPS_DELAY), when the key code is caps lock. As a result, in most operating systems, the caps lock key will not register since it's cycled too quickly. This change mirrors the structure of tap_code, but using the same function wait_ms, as is currently in tap_code16, to add this delay in, if the key code is caps lock.

This is consistent with existing documentation which says that the 16 version of the function behaves "similar" to the non 16 version.

These functions work similar to their regular counterparts, but allow you to use modded keycodes (with Shift, Alt, Control, and/or GUI applied to them).
- https://docs.qmk.fm/#/feature_macros

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 29, 2021
@Ga68
Copy link
Author

Ga68 commented Jan 13, 2022

I re-read the documents to (try to) make sure I'm not asking a question that's answered elsewhere. If it is, I'm sorry; this is only my second PR for QMK so there's a bunch of the process here that's still quite new. Is there anything I need to do on this one to get it merged? I see it's approved and I'm guessing that it's just waiting for the next "round" of core fixes, but I wanted to make sure I wasn't mistaken in that assumption and it is not waiting on action from me.

@drashna drashna requested a review from a team January 13, 2022 02:13
@precondition
Copy link
Contributor

I re-read the documents to (try to) make sure I'm not asking a question that's answered elsewhere. If it is, I'm sorry; this is only my second PR for QMK so there's a bunch of the process here that's still quite new. Is there anything I need to do on this one to get it merged? I see it's approved and I'm guessing that it's just waiting for the next "round" of core fixes, but I wanted to make sure I wasn't mistaken in that assumption and it is not waiting on action from me.

No, you don't need to be doing something more. It's just a matter of time before a second collaborator reviews this PR and approves it.

@drashna drashna changed the base branch from master to develop January 29, 2022 07:03
@drashna drashna merged commit 1f59fe6 into qmk:develop Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants