Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corne and planck keyboards keymaps #15570

Merged
merged 14 commits into from
Mar 26, 2022
Merged

corne and planck keyboards keymaps #15570

merged 14 commits into from
Mar 26, 2022

Conversation

antosha417
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@antosha417 antosha417 changed the title corne keyboard keymap corne and planck keyboards keymaps Dec 24, 2021
drashna
drashna requested changes Dec 24, 2021
View reviewed changes
keyboards/crkbd/keymaps/antosha417/config.h Show resolved Hide resolved
keyboards/crkbd/keymaps/antosha417/config.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/antosha417/keymap.c Show resolved Hide resolved
keyboards/crkbd/keymaps/antosha417/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/antosha417/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/keymaps/antosha417/mod_tap_keys.h Show resolved Hide resolved
keyboards/planck/keymaps/antosha417/keymap.c Show resolved Hide resolved
keyboards/planck/keymaps/antosha417/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/keymaps/antosha417/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/keymaps/antosha417/keymap.c Show resolved Hide resolved
@antosha417 antosha417 requested a review from drashna January 14, 2022 18:12
@antosha417
Copy link
Contributor Author

@drashna, could you take one more look?
I think I fixed all the problems

drashna
drashna requested changes Jan 22, 2022
View reviewed changes
keyboards/crkbd/keymaps/antosha417/config.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/antosha417/config.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/antosha417/keymap.c Show resolved Hide resolved
drashna
drashna approved these changes Jan 22, 2022
View reviewed changes
keyboards/crkbd/keymaps/antosha417/config.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/antosha417/keymap.c Show resolved Hide resolved
@drashna drashna requested a review from a team January 22, 2022 17:58
fauxpark
fauxpark requested changes Jan 22, 2022
View reviewed changes
keyboards/planck/keymaps/antosha417/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/antosha417/config.h Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Jan 27, 2022
View reviewed changes
keyboards/planck/keymaps/antosha417/readme.md Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/antosha417/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/keymaps/antosha417/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team January 29, 2022 07:02
@antosha417
Copy link
Contributor Author

@drashna @fauxpark do I need to do something? Seems like this pr is stuck

@antosha417
Copy link
Contributor Author

@drashna @fauxpark can you please merge this pr if there is no more things to fix?

@antosha417
Copy link
Contributor Author

antosha417 commented Mar 24, 2022 •
edited
Loading

@zvecr, hi!
Maybe you can help me?
I think this pr is ready to be merged. What am I missing?

@drashna drashna merged commit 53a88af into qmk:master Mar 26, 2022
@antosha417 antosha417 deleted the antosha417 branch April 13, 2022 14:19
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@antosha417 @drashna
@fauxpark @zykrah
[Keymap] corne and planck keyboards keymaps (qmk#15570)
ee4bd3a 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antosha417 @drashna @fauxpark