-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'capslock backlight' feature to Iron180 #15462
Conversation
Any reason to go custom over cores |
As far as I tested, |
That sounds like something that should be fixed in core code, rather than reimplemented here. |
I DM'd @zvecr at length about this. The thing is, the core code implementation's intent is to treat breathing as a different state than backlight itself; in other words, breathing is not supposed to be turned on and off when backlight is respectively enabled or disabled because they are supposed to be two different features. Now since zvecr is a developer and a key member I took his statement as a somewhat "official" QMK opinion on it. However, the intended effect I want for Iron180 is for breathing to be turned on and off with the backlight, hence why the keyboard-level implementation in favour of the core-level implementation. So in this discussion me and zvecr agreed that maybe we ought to leave the core implementation as it is; the discussion now is what would be the best way to implement this feature in the keyboard-level. According to zvecr the functions I used, videlicet, EDIT: typos |
* Add 'capslock backlight' capability to Iron180 * Update readme * Revers CAPSLOCK_BACKLIGHT back to default
* Add 'capslock backlight' capability to Iron180 * Update readme * Revers CAPSLOCK_BACKLIGHT back to default
Description
Some Iron180 users have shown interest in only having the caps lock LED soldered and for it to work as a caps lock indicator.
This PR adds a
CAPSLOCK_BACKLIGHT
define inconfig.h
which in turn enables a led state function iniron180.c
that toggles backlight and breathing according to caps lock. The PR also contains README instructions.Types of Changes
Checklist