Tidy up SLEEP_LED_ENABLE rules
#15362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
via
zvecr
approved these changes
Nov 30, 2021
sigprof
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
The comment is at least partially true (on AVR this feature uses a timer specified by SLEEP_LED_TIMER, which is 1 by default, but can also be 3 — these are the same timers that can be used by the backlight or audio code, but there are no checks whether the specified timer is actually not used by those subsystems, except possibly a duplicate definition of the TIMERx_COMPA_vect ISR).
BTW, this feature also invokes led_set() from an interrupt handler, which might be unsafe, depending on what is done in led_update_kb() or even led_update_user().
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Dec 2, 2021
* qmk/develop: (76 commits) Update ReadMe for the Roopad (qmk#15380) Tidy up existing i2c_master implementations (qmk#15376) Remove pointless `CUSTOM_MATRIX = no` (qmk#15383) Remove manual enable of LTO within keyboards (qmk#15377) [Keyboard] Han60 QMK / VIA Support (qmk#15332) Convert ai03/orbit to SPLIT_KEYBOARD (qmk#15340) Convert not_so_minidox to SPLIT_KEYBOARD (qmk#15306) Tidy up `SLEEP_LED_ENABLE` rules (qmk#15362) [Keyboard] Add support for Mode SixtyFive M65HA and M65HI (qmk#14685) Implement MAGIC_TOGGLE_CONTROL_CAPSLOCK (qmk#15368) Rename Layout Macros for TKLs with F13 keys (qmk#15361) [Docs] Reorder functions in Understanding QMK (qmk#15357) [Keyboard] Fix up Endgame34 (qmk#15366) [Keyboard] Fix compilation issues for Ploopy Trackball classic (qmk#15364) [Keyboard] Add missng define for 4x6 Tractyl Manuform (qmk#15363) [Core] Added chconf.h for WB32 (qmk#15359) [Keyboard] kangaroo improvements (qmk#15350) [Keyboard] Convert ergoinu to SPLIT_KEYBOARD (qmk#15305) [Keymap] Keebio Sinc layout with macOS support (qmk#15324) Fixup paths for `ramonimbao/wete/v2`. (qmk#15360) ...
rudism
pushed a commit
to rudism/qmk_firmware
that referenced
this pull request
Jan 16, 2022
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature isn't used very much, and its rule in the template has a rather strange comment attached to it...
Types of Changes
Issues Fixed or Closed by This PR
Checklist