Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mini winni #15341

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Add mini winni #15341

merged 6 commits into from
Mar 8, 2022

Conversation

matthewdias
Copy link
Contributor

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 28, 2021
@matthewdias matthewdias mentioned this pull request Nov 28, 2021
Merged
6 tasks
zvecr
zvecr requested changes Nov 28, 2021
View reviewed changes
keyboards/mini_winni/mini_winni.h Outdated Show resolved Hide resolved
keyboards/mini_winni/info.json Outdated Show resolved Hide resolved
drashna
drashna requested changes Nov 28, 2021
View reviewed changes
keyboards/mini_winni/config.h Outdated Show resolved Hide resolved
@matthewdias @drashna @zvecr
Apply suggestions from code review
e6e97ee 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
@matthewdias matthewdias requested review from zvecr and drashna December 9, 2021 05:04
drashna
drashna requested changes Dec 9, 2021
View reviewed changes
keyboards/mini_winni/rules.mk Outdated Show resolved Hide resolved
@matthewdias matthewdias requested a review from drashna January 5, 2022 05:58
drashna
drashna requested changes Jan 7, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a readme

@matthewdias matthewdias requested a review from drashna February 24, 2022 04:40
fauxpark
fauxpark requested changes Feb 24, 2022
View reviewed changes
keyboards/winkeys/mini_winni/rules.mk Outdated Show resolved Hide resolved
@matthewdias matthewdias requested a review from fauxpark February 27, 2022 20:11
@fauxpark fauxpark requested a review from a team February 28, 2022 12:30
@drashna drashna merged commit 4d2ae22 into qmk:master Mar 8, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@matthewdias @drashna
@zvecr @fauxpark @zykrah
[Keyboard] Add mini winni (qmk#15341)
14cf19d 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewdias @drashna @fauxpark @zvecr