Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to pointing_device_handle_buttons #15313

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Conversation

0xcharly
Copy link
Contributor

Description

pointing_device_handle_buttons(…) expects 3 arguments, the first one being an uint8_t corresponding to the report_mouse_t.buttons field to update.

Without this change, the ploopyco/trackball firmware fails to compile when MOUSEKEY_ENABLE is not defined.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

`pointing_device_handle_buttons(…)` expects 3 arguments, the first one being an `uint8_t` corresponding to the `report_mouse_t.buttons` field to update.
Copy link
Member

@daskygit daskygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, lines up with the trackball mini too.

@drashna drashna merged commit 0e65483 into qmk:develop Nov 27, 2021
@0xcharly 0xcharly deleted the patch-1 branch November 27, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants