Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Revert Assymmetrical Split Encoder support (#12090) #15311

Merged
merged 2 commits into from
Nov 27, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 27, 2021

Currently, it causes the encoder update function to be spammed at startup. A fix isn't clear, nor will it be timely, most likely. Reverting for now, until a proper fix can be implemented.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from tzarc and a team November 27, 2021 03:30
@tzarc tzarc merged commit 4d0dd1e into qmk:develop Nov 27, 2021
@drashna drashna deleted the bug/encoders branch November 27, 2021 05:36
@mtei mtei mentioned this pull request Feb 16, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants