Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up adjustable ws2812 timing #15299

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Tidy up adjustable ws2812 timing #15299

merged 2 commits into from
Nov 25, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 25, 2021 •
edited
Loading

Description

  • Docs too verbose and added to wrong section
  • Tmiings moved to header and applied in more scenarios
    • Removed WS2812_RES as WS2812_TRST_US already existed
    • A bit hesitant to introduce WS2812_T0L and WS2812_T1L to AVR at this point

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team November 25, 2021 18:31
@zvecr zvecr merged commit 5e9c29d into qmk:develop Nov 25, 2021
@Gondolindrim
Copy link
Contributor

Thanks @zvecr !

@Gondolindrim Gondolindrim mentioned this pull request Nov 28, 2021
Merged
14 tasks
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Dec 2, 2021
Merge remote-tracking branch 'qmk/develop' into develop
f4a446b 
* qmk/develop:
  More headroom. (qmk#15302)
  More headroom. (qmk#15301)
  Documentation typo fix (qmk#15298)
  New feature: `DYNAMIC_TAPPING_TERM_ENABLE` (qmk#11036)
  Tidy up adjustable ws2812 timing (qmk#15299)
  Add ifndef to WS2812 timing constraints (qmk#14678)
  Add Retro Shift (Auto Shift for Tap Hold via Retro Tapping) and Custom Auto Shifts (qmk#11059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @Gondolindrim @drashna