Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] New Keyboard - Waka60 #15173

Merged
merged 7 commits into from
Dec 11, 2021
Merged

[Keyboard] New Keyboard - Waka60 #15173

merged 7 commits into from
Dec 11, 2021

Conversation

kylemccreery
Copy link
Contributor

@kylemccreery kylemccreery commented Nov 15, 2021 •
edited
Loading

Description

Initial PR for adding the Waka60 keyboard kit by MechWild. This is the default, VIA, and audio enabled keymaps.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 15, 2021
drashna
drashna requested changes Nov 16, 2021
View reviewed changes
keyboards/mechwild/waka60/config.h Outdated Show resolved Hide resolved
keyboards/mechwild/waka60/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 16, 2021 01:11
fauxpark
fauxpark requested changes Nov 16, 2021
View reviewed changes
keyboards/mechwild/waka60/waka60.h Outdated Show resolved Hide resolved
keyboards/mechwild/waka60/readme.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 19, 2021 04:01
@kylemccreery
Copy link
Contributor Author

@fauxpark Just checking if those changes that were made were adequate for what you expected.

fauxpark
fauxpark requested changes Dec 10, 2021
View reviewed changes
keyboards/mechwild/waka60/rules.mk Outdated Show resolved Hide resolved
@drashna drashna merged commit 0dc2bdb into qmk:master Dec 11, 2021
@drashna
Copy link
Member

drashna commented Dec 11, 2021

Thanks!

@kylemccreery kylemccreery mentioned this pull request Dec 17, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylemccreery @drashna @fauxpark