Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff logic to python format subcommand #15156

Merged
merged 5 commits into from
Nov 17, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 14, 2021

Description

Broken out from 11910.

More alignment of functionality between existing formatting commands.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr force-pushed the feature/pyformat_diff branch from 66af9ad to 280c46e Compare November 17, 2021 20:07
@zvecr zvecr requested a review from a team November 17, 2021 20:12
@zvecr zvecr merged commit cd50fdf into qmk:master Nov 17, 2021
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 3, 2022
* Add diff logic to python format subcommand

* Update test

* Add in filter per format-c

* fix tests

* Update new workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants