Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Pachi RGB Rev 2 #15141

Merged
merged 13 commits into from
Nov 16, 2021
Merged

[Keyboard] Add Pachi RGB Rev 2 #15141

merged 13 commits into from
Nov 16, 2021

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Nov 13, 2021

Description

Add Pachi RGB Rev 2 - duplex matrix and using L422KB instead of L422CB (rev1)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Include Pachi RGB Rev 2

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team November 15, 2021 23:09
drashna
drashna requested changes Nov 15, 2021
View reviewed changes
keyboards/xelus/pachi/rgb/rev1/config.h Show resolved Hide resolved
keyboards/xelus/pachi/rgb/rev1/readme.md Outdated Show resolved Hide resolved
keyboards/xelus/pachi/rgb/rev2/config.h Show resolved Hide resolved
keyboards/xelus/pachi/rgb/rev2/rules.mk Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Nov 15, 2021
View reviewed changes
keyboards/xelus/pachi/rgb/rev2/rules.mk Outdated Show resolved Hide resolved
keyboards/xelus/pachi/rgb/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/xelus/pachi/rgb/rev2/readme.md Outdated Show resolved Hide resolved
keyboards/xelus/pachi/rgb/rev1/rev1.c Outdated Show resolved Hide resolved
keyboards/xelus/pachi/rgb/rev1/readme.md Outdated Show resolved Hide resolved
keyboards/xelus/pachi/rgb/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/xelus/pachi/rgb/rev1/rev1.c Outdated Show resolved Hide resolved
Xelus22 and others added 10 commits November 16, 2021 11:04
@Xelus22 @drashna
Update keyboards/xelus/pachi/rgb/rev1/readme.md
12724aa 
Co-authored-by: Drashna Jaelre <[email protected]>
@Xelus22 @drashna
Update keyboards/xelus/pachi/rgb/rev2/rules.mk
2bb9b0e 
Co-authored-by: Drashna Jaelre <[email protected]>
@Xelus22 @fauxpark
Update keyboards/xelus/pachi/rgb/rev2/rules.mk
773ca21 
Co-authored-by: Ryan <[email protected]>
@Xelus22 @fauxpark
Update keyboards/xelus/pachi/rgb/rev2/rev2.c
f4686bd 
Co-authored-by: Ryan <[email protected]>
@Xelus22 @fauxpark
Update keyboards/xelus/pachi/rgb/rev1/rev1.c
057eb2e 
Co-authored-by: Ryan <[email protected]>
@Xelus22 @fauxpark
Update keyboards/xelus/pachi/rgb/rev2/readme.md
0e32457 
Co-authored-by: Ryan <[email protected]>
@Xelus22 @fauxpark
Update keyboards/xelus/pachi/rgb/rev2/rev2.c
007f6fd 
Co-authored-by: Ryan <[email protected]>
@Xelus22 @fauxpark
Update keyboards/xelus/pachi/rgb/rev1/rev1.c
961f100 
Co-authored-by: Ryan <[email protected]>
@Xelus22 @drashna
Update keyboards/xelus/pachi/rgb/rev1/config.h
e0371ba 
Co-authored-by: Drashna Jaelre <[email protected]>
@Xelus22 @drashna
Update keyboards/xelus/pachi/rgb/rev2/config.h
e3bccf8 
Co-authored-by: Drashna Jaelre <[email protected]>
@Xelus22 Xelus22 requested review from fauxpark and drashna November 16, 2021 00:49
@drashna drashna merged commit 053a970 into qmk:master Nov 16, 2021
@Xelus22 Xelus22 mentioned this pull request Dec 12, 2021
Merged
6 tasks
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 3, 2022
@Xelus22 @drashna
@fauxpark @coquizen
[Keyboard] Add Pachi RGB Rev 2 (qmk#15141)
7febecc 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xelus22 @drashna @fauxpark