Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RGB matrix & LED Matrix support for IS31FL3742A, IS31FL3743A, IS31FL3745, IS31FL3746A #14989

Merged
merged 28 commits into from
Feb 6, 2022

Conversation

MasterSpoon
Copy link

Adding a ISSI Common driver that adds support for 4 newer drivers and sets up backbone to bring further drivers onboard through a more central process.

Have added hooks for RGB and LED Matrix to allow selection of IS31FLCOMMON driver.
Added driver to allow swapping in config files for different ISSI models as all share common operation
Added config files for IS31FL3742A, IS31FL3743A, IS31FL3745, IS31FL3746A
Updated docs with how to configure new features

Have been able to test on hardware IS31FL3743A, the other three are assumed to be functional by association as they are operated in the same manner. Have done a dummy config and compile for all the 3 other drivers to ensure they compile correctly however have not been hardware tested at this stage.

I have used the existing configurations and drivers as examples of how to layout and configure to try keep my coded in line with the current coding in the repo.

Both the led_matrix_drivers.c and rgb_matrix_drivers.c have drivers that are the fall back if nothing else defined so have placed hooks for common driver before there.

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

added initial setup for ISSI drivers with common driver
Updated ISSI Drivers to current revision from My-Keyboards branch
updating formatting in .h files for matrix as
removing double tab didn't fix on github
Moved register unlock function out of write multi to allow to be used with drivers without unlock register
made note clearer for ssr being passed
update of docs for ISSI drivers and update drivers removing chips not to be supported yet
@zvecr zvecr changed the base branch from master to develop October 30, 2021 15:02
@drashna
Copy link
Member

drashna commented Oct 30, 2021

Has some merge conflicts

@github-actions github-actions bot removed the keymap label Oct 31, 2021
@MasterSpoon
Copy link
Author

Updated conflicts and formatted in line with #14760 (which is much nicer then it was by the way, thank you fauxpark)

@drashna
Copy link
Member

drashna commented Oct 31, 2021

Discord discussion about this, starting here:
https://discord.com/channels/440868230475677696/867530715192885269/904495820995432448

for future drashna's reference

Changed from selecting common driver then defining which one in config to selecting model in rules.mk as per suggestions.
@drashna
Copy link
Member

drashna commented Nov 2, 2021

This has some merge conflicts that need to be resolved.

@MasterSpoon
Copy link
Author

Resolved merge conflicts.

@drashna drashna requested a review from a team November 3, 2021 02:41
docs/feature_rgb_matrix.md Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jan 3, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with the relevant features, but I don't see anything concerning here.

__attribute__ ((weak)) ✔️

@drashna drashna requested a review from a team February 5, 2022 02:40
@drashna drashna merged commit 0452ad9 into qmk:develop Feb 6, 2022
@MasterSpoon MasterSpoon deleted the ISSI_drivers branch February 7, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants