-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RGB matrix & LED Matrix support for IS31FL3742A, IS31FL3743A, IS31FL3745, IS31FL3746A #14989
Conversation
added initial setup for ISSI drivers with common driver
Updated ISSI Drivers to current revision from My-Keyboards branch
updating formatting in .h files for matrix as
removing double tab didn't fix on github
Moved register unlock function out of write multi to allow to be used with drivers without unlock register
made note clearer for ssr being passed
update of docs for ISSI drivers and update drivers removing chips not to be supported yet
Has some merge conflicts |
reformatted led / rgb matrix drivers inline with pull request qmk#14760
Updated conflicts and formatted in line with #14760 (which is much nicer then it was by the way, thank you fauxpark) |
Discord discussion about this, starting here: for future drashna's reference |
Changed from selecting common driver then defining which one in config to selecting model in rules.mk as per suggestions.
This has some merge conflicts that need to be resolved. |
Resolved merge conflicts. |
Co-authored-by: Xelus22 <[email protected]>
Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super familiar with the relevant features, but I don't see anything concerning here.
__attribute__ ((weak))
✔️
Adding a ISSI Common driver that adds support for 4 newer drivers and sets up backbone to bring further drivers onboard through a more central process.
Have added hooks for RGB and LED Matrix to allow selection of IS31FLCOMMON driver.
Added driver to allow swapping in config files for different ISSI models as all share common operation
Added config files for IS31FL3742A, IS31FL3743A, IS31FL3745, IS31FL3746A
Updated docs with how to configure new features
Have been able to test on hardware IS31FL3743A, the other three are assumed to be functional by association as they are operated in the same manner. Have done a dummy config and compile for all the 3 other drivers to ensure they compile correctly however have not been hardware tested at this stage.
I have used the existing configurations and drivers as examples of how to layout and configure to try keep my coded in line with the current coding in the repo.
Both the led_matrix_drivers.c and rgb_matrix_drivers.c have drivers that are the fall back if nothing else defined so have placed hooks for common driver before there.
Issues Fixed or Closed by This PR
Checklist