Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop-gap forward-port Drop LED features for CTRL and ALT #14967

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

just-another-jxliu
Copy link
Contributor

@just-another-jxliu just-another-jxliu commented Oct 27, 2021

Description

Forward-port of LED features from Massdrop QMK fork:

  • Mode that turns off every other edge LED
  • Ability to decrease brightness of only edge LEDs
  • Ability to set the ratio of key to edge LED brightness (unused by keymap)
  • Added up/down, radial inward/outward LED pattern directions
  • Factory debug mode

Updates the following keymaps to add keys using the above feature set:

  • massdrop/alt/default_md
  • massdrop/alt/mac_md
  • massdrop/ctrl/default_md
  • massdrop/ctrl/mac_md

This is a stop-gap change while a larger rework of QMK support for the current generation of Drop keyboards is in progress.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@just-another-jxliu just-another-jxliu changed the base branch from master to develop October 27, 2021 21:58
@just-another-jxliu just-another-jxliu marked this pull request as ready for review October 29, 2021 00:40
@zvecr zvecr requested a review from a team October 29, 2021 17:38
@drashna drashna merged commit 736d9fa into qmk:develop Oct 29, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants