Improve Adafruit BLE configuration defines #14749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Oct 8, 2021
ptrxyz
pushed a commit
to ptrxyz/qmk_firmware
that referenced
this pull request
Apr 9, 2022
* Improve Adafruit BLE configuration defines * Formatting
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Jun 3, 2022
* Improve Adafruit BLE configuration defines * Formatting
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Improve Adafruit BLE configuration defines * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By convention these defines should be in
SCREAMING_SNAKE_CASE.The frequency define has been changed to
ADAFRUIT_BLE_SCK_DIVISORas there is noF_CPUequivalent for ARM, so it cannot be easily calculated automatically. It defaults to 2, the value it would be for a Feather 32U4 running at 8MHz with a 4MHz SPI clock speed. ARM users will likely always need to increase this as those chips run at much higher speeds, and even with the /2 division, the BLE module probably won't be able to keep up.Types of Changes
Issues Fixed or Closed by This PR
Checklist