Make ChibiOS PAL interactions less STM32 specific - Round 2 #14456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Sep 15, 2021
tzarc
approved these changes
Sep 15, 2021
KarlK90
reviewed
Sep 16, 2021
| @@ -42,13 +42,13 @@ | |||
| # if defined(USE_GPIOV1) | |||
| # define WS2812_OUTPUT_MODE PAL_MODE_ALTERNATE_PUSHPULL | |||
| # else | |||
| # define WS2812_OUTPUT_MODE PAL_MODE_ALTERNATE(WS2812_PWM_PAL_MODE) | PAL_MODE_OUTPUT_PUSHPULL | PAL_OUTPUT_SPEED_HIGHEST | PAL_PUPDR_FLOATING | |||
| # define WS2812_OUTPUT_MODE PAL_MODE_ALTERNATE(WS2812_PWM_PAL_MODE) | PAL_OUTPUT_TYPE_PUSHPULL | PAL_OUTPUT_SPEED_HIGHEST | PAL_PUPDR_FLOATING | |||
| # endif | |||
| #else | |||
| # if defined(USE_GPIOV1) | |||
| # define WS2812_OUTPUT_MODE PAL_MODE_ALTERNATE_PUSHPULL | |||
There was a problem hiding this comment.
This should be PAL_MODE_ALTERNATE_OPENDRAIN got some funky lightning effects without it. (Line 49)
There was a problem hiding this comment.
I have opened a quick PR #14474 to fix it.
14 tasks
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Sep 19, 2021
* qmk/develop: (69 commits) Use opendrain pin with external pullup again (qmk#14474) Add i2c defaults for Convert to Proton C (qmk#14470) [Keyboard] Increase the way to add oled code for helix/rev3. (qmk#14426) [Bug] fix logical minimum in Programmable Button rdesc (qmk#14464) Adds optional hebrew layout (Unicode) (qmk#14156) New CLI subcommand to create clang-compatible compilation database (`compile_commands.json`) (qmk#14370) [Keyboard] Add the Idobao ID96 keyboard (qmk#14371) [Keyboard] Add FJLabs TF60 Variants and TF65 Variant (qmk#14392) [Keyboard] Add Absolute Designs AD65 Keyboard (qmk#14391) [Bug] Fix descriptor for USB Programmable Buttons (qmk#14455) Make ChibiOS PAL interactions less STM32 specific - Round 2 (qmk#14456) core: fix compilation issues with USB programmable buttons (qmk#14454) [Keyboard] add Matrix Me (qmk#14331) [Keyboard] Replaced Maker Keyboards & FJLabs Legacy Code (qmk#14393) [Keyboard] Add `NO_LED` positions to match key matrix. (qmk#14417) [Keymap] A slight improvement to my own ErgoDox keymap (qmk#14425) [Keymap] Trying again with Prime-e update! (qmk#14429) [Keyboard] Update lighting effects for xbows keyboard (qmk#14432) [Docs] add sync options heading, update led indicators (qmk#14441) [Bug] Fix IS31fl3741 driver to accept 1 or 2 addresses (qmk#14451) ...
ptrxyz
pushed a commit
to ptrxyz/qmk_firmware
that referenced
this pull request
Apr 9, 2022
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per #14439 (comment), seems I was a little in my use of the existing defines.
Types of Changes
Issues Fixed or Closed by This PR
Checklist