Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyboard]Add v1 to jones keyboard #14405

Merged
merged 16 commits into from
Mar 10, 2022
Merged

[keyboard]Add v1 to jones keyboard #14405

merged 16 commits into from
Mar 10, 2022

Conversation

jpskenn
Copy link

@jpskenn jpskenn commented Sep 12, 2021

Description

Add new version of hardware, v1 to Jones keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • NONE

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 12, 2021
drashna
drashna requested changes Sep 16, 2021
View reviewed changes
keyboards/jones/v1/rules.mk Outdated Show resolved Hide resolved
drashna
drashna requested changes Sep 17, 2021
View reviewed changes
keyboards/jones/v1/keymaps/via/config.h Show resolved Hide resolved
keyboards/jones/v1/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@jpskenn jpskenn requested a review from drashna September 18, 2021 01:50
@drashna drashna requested a review from a team September 19, 2021 03:27
fauxpark
fauxpark requested changes Sep 19, 2021
View reviewed changes
keyboards/jones/v1/rules.mk Show resolved Hide resolved
keyboards/jones/v1/rules.mk Outdated Show resolved Hide resolved
@jpskenn jpskenn requested a review from fauxpark September 19, 2021 12:15
@stale
Copy link

stale bot commented Nov 16, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@jpskenn
Copy link
Author

jpskenn commented Nov 16, 2021

@fauxpark
If you're available, could you review changed lines at "rules.mk".

@drashna drashna requested a review from a team November 19, 2021 04:34
@stale stale bot removed the awaiting changes label Nov 19, 2021
@stale
Copy link

stale bot commented Jan 3, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

fauxpark
fauxpark requested changes Jan 6, 2022
View reviewed changes
keyboards/jones/v1/rules.mk Outdated Show resolved Hide resolved
@stale stale bot removed the awaiting changes label Jan 6, 2022
@drashna drashna requested a review from a team January 11, 2022 01:21
@noroadsleft noroadsleft merged commit 9d0153d into qmk:master Mar 10, 2022
@noroadsleft
Copy link
Member

Thanks!

Vasilis pushed a commit to Vasilis/qmk_firmware that referenced this pull request Mar 10, 2022
@jpskenn
[keyboard]Add v1 to jones keyboard (qmk#14405)
d331be2 
* Change for latest information.

* Update from v03_1 to v1.

* Add v1 files.

* Remove finished todo comment.

* Fix COLUMN number, from "a" to "9".

* Formatting

* Update keyboards/jones/v1/rules.mk

* Add license header.

qmk#14405 (comment)

* Implement better way to handle keycode for encoder.

Use "action_exec" instead of "tap_code16"
qmk#14405 (comment)

* Move External EEPROM config  to keyboard level

* Move the lest of DYNAMIC_KEYMAP config  to keyboard level

qmk#14405 (comment)

* Move the rest of DYNAMIC_KEYMAP config  to keyboard level

qmk#14405 (comment)

* Update keyboards/jones/v1/rules.mk

* Update keyboards/jones/v1/rules.mk

* Update keyboards/jones/v1/rules.mk
zykrah pushed a commit to zykrah/vial-qmk that referenced this pull request Jul 2, 2022
@jpskenn @zykrah
[keyboard]Add v1 to jones keyboard (#14405)
8aeb1a2 
* Change for latest information.

* Update from v03_1 to v1.

* Add v1 files.

* Remove finished todo comment.

* Fix COLUMN number, from "a" to "9".

* Formatting

* Update keyboards/jones/v1/rules.mk

* Add license header.

qmk/qmk_firmware#14405 (comment)

* Implement better way to handle keycode for encoder.

Use "action_exec" instead of "tap_code16"
qmk/qmk_firmware#14405 (comment)

* Move External EEPROM config  to keyboard level

* Move the lest of DYNAMIC_KEYMAP config  to keyboard level

qmk/qmk_firmware#14405 (comment)

* Move the rest of DYNAMIC_KEYMAP config  to keyboard level

qmk/qmk_firmware#14405 (comment)

* Update keyboards/jones/v1/rules.mk

* Update keyboards/jones/v1/rules.mk

* Update keyboards/jones/v1/rules.mk
zykrah pushed a commit to zykrah/vial-qmk that referenced this pull request Jul 6, 2022
@jpskenn @zykrah
[keyboard]Add v1 to jones keyboard (#14405)
08b4540 
* Change for latest information.

* Update from v03_1 to v1.

* Add v1 files.

* Remove finished todo comment.

* Fix COLUMN number, from "a" to "9".

* Formatting

* Update keyboards/jones/v1/rules.mk

* Add license header.

qmk/qmk_firmware#14405 (comment)

* Implement better way to handle keycode for encoder.

Use "action_exec" instead of "tap_code16"
qmk/qmk_firmware#14405 (comment)

* Move External EEPROM config  to keyboard level

* Move the lest of DYNAMIC_KEYMAP config  to keyboard level

qmk/qmk_firmware#14405 (comment)

* Move the rest of DYNAMIC_KEYMAP config  to keyboard level

qmk/qmk_firmware#14405 (comment)

* Update keyboards/jones/v1/rules.mk

* Update keyboards/jones/v1/rules.mk

* Update keyboards/jones/v1/rules.mk
@jpskenn jpskenn mentioned this pull request Nov 2, 2023
Open
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpskenn @noroadsleft @drashna @fauxpark