Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable de-ghosting for RGB matrix on the IS31L3733 #14281

Closed

Conversation

donicrosby
Copy link

Description

Currently RGB matrixes for the IS31L3733 have ghosting issues with the LEDs. Any LEDs used as indicators or just plain off in the matrix glow faintly which isn't ideal. I have added a option to be set in a keyboards config.h that allows for makers and users to enable the on-chip resistors for all of the drivers on the board so that this ghosting is eliminated.

I have set the default value to allow for ghosting (0 ohm resistor) so as to stay backwards compatible and not cause power issues with older boards.

The datasheet recommends enabling the 32k ohm resistor as it is only on during the blanking time so there shouldn't be any dimming with the LEDs when they are on. If you want me to set that as the default (would make sense that you wouldn't want ghosting on the matrix) I can do that as well.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@donicrosby donicrosby changed the base branch from master to develop September 3, 2021 23:24
@drashna drashna requested a review from a team September 18, 2021 07:04
@donicrosby
Copy link
Author

Would it be wise to update all of the ISSI RGB drivers that have on-chip pull-up/down resistors follow the same syntax and the documentation is updated to reflect that?

@drashna
Copy link
Member

drashna commented Sep 19, 2021

Would it be wise to update all of the ISSI RGB drivers that have on-chip pull-up/down resistors follow the same syntax and the documentation is updated to reflect that?

Yeah, I think it would be worth adding to all of the controllers that support it.

@donicrosby donicrosby closed this Sep 19, 2021
@donicrosby donicrosby deleted the issi-31fl3733-de-ghost-enable branch September 19, 2021 06:54
@donicrosby donicrosby restored the issi-31fl3733-de-ghost-enable branch September 19, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants