Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor schema fixes #14200

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Minor schema fixes #14200

merged 1 commit into from
Jun 18, 2022

Conversation

yanfali
Copy link
Contributor

@yanfali yanfali commented Aug 28, 2021

Validating using nodejs AJV

Description

  • specify the schema draft
  • min -> minimum
  • max -> maximum
  • minLength -> minItems
  • maxLength -> maxItems

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from skullydazed August 29, 2021 21:53
@stale
Copy link

stale bot commented Oct 24, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale
Copy link

stale bot commented Jan 9, 2022

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.

@stale stale bot closed this Jan 9, 2022
@tzarc tzarc reopened this Jan 9, 2022
@stale stale bot removed the awaiting changes label Jan 9, 2022
@tzarc tzarc force-pushed the yanfali-json-schema-updates branch from 9dc4be7 to 9932d88 Compare June 17, 2022 23:00
@tzarc tzarc requested review from a team and removed request for skullydazed June 17, 2022 23:00
@tzarc
Copy link
Member

tzarc commented Jun 17, 2022

I've rebased this on top of current master, applied the relevant changes.

@tzarc tzarc force-pushed the yanfali-json-schema-updates branch from 9932d88 to b25c59a Compare June 17, 2022 23:02
@yanfali @tzarc
Minor schema fixes
eecbb83 
- specify the schema draft
- min -> minimum
- max -> maximum
- minLength -> minItems
- maxLength -> maxItems

Validating using AJV
@tzarc tzarc force-pushed the yanfali-json-schema-updates branch from b25c59a to eecbb83 Compare June 17, 2022 23:11
@zvecr zvecr changed the base branch from master to develop June 18, 2022 01:35
@zvecr zvecr merged commit 7b3ee1d into qmk:develop Jun 18, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@yanfali @zykrah
Minor schema fixes (qmk#14200)
37b45dc 
Validating using AJV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanfali @tzarc @zvecr