Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wait_us overflow in matrix for dactyl based boards #14039

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Fix wait_us overflow in matrix for dactyl based boards #14039

merged 1 commit into from
Aug 17, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 17, 2021

Description

Change wait_us(1000000) to wait_ms(1000) in dactyl and pterodactyl keyboards to prevent overflowing of uint16.

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Issues Fixed or Closed by This PR

  • Tzarc CI

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team August 17, 2021 08:39
@drashna drashna requested a review from fauxpark August 17, 2021 08:51
@drashna drashna requested a review from a team August 17, 2021 09:16
@drashna drashna merged commit e443fa2 into qmk:develop Aug 17, 2021
@drashna drashna deleted the keyboard/fix_timers branch August 17, 2021 15:20
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @nhongooi
Fix wait_us overflow in matrix for dactyl based boards (qmk#14039)
0e205d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@mtei mtei mtei approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @mtei @fauxpark