Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QWIIC OLED optimization (size reduction and speed improvements) and added new font option #14018

Closed
wants to merge 4 commits into from

Conversation

infinityis
Copy link
Contributor

@infinityis infinityis commented Aug 15, 2021

Description

Resolved "TODOs" for optimizing horizontal and vertical line drawing. New implementation reduces compiled code size by approximately 60 bytes for applications drawing both horizontal and vertical lines. Execution speed is also improved by eliminating multiplication from loops and drawing vertical up to lines 8 pixels at a time.

Added a third font (font5x7lite) which is a subset of the existing 5x7 font. It includes the same character subset as the 8x16 font which is mostly the alphanumerics and common symbols. If this font subset is used in lieu of the complete 5x7 font, the compiled file size decreases by almost 800 bytes.

Compiled file size reductions were measured for Atmega32u4 as a target.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation. (specifically: new font option)
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 15, 2021
@drashna drashna changed the title OLED optimization (size reduction and speed improvements) and added new font option QWIIC OLED optimization (size reduction and speed improvements) and added new font option Aug 17, 2021
@stale
Copy link

stale bot commented Oct 11, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna
Copy link
Member

drashna commented Oct 12, 2021

Just a heads up, unfortunately this is pretty much the opposite direction that we're headed.

#14174

Specifically, we're trying to consolidate the drivers and then move to Quantum Painter for a much more unified interface/api.

@drashna drashna closed this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants