Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] Improve andrebrait keymap #13985

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

andrebrait
Copy link
Contributor

Description

Remove the dependency on lib8tion. I was using sin8 in order to get either a 1 or a 0, which can be accomplished with just some bitwise operations, so I just changed it. This makes things a lot simpler. I also renamed some defines inside the keymap file to make it slightly easier to parse when reading.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team August 13, 2021 18:02
@drashna
Copy link
Member

drashna commented Aug 13, 2021

Thanks!

@drashna drashna merged commit 5711a3b into qmk:develop Aug 13, 2021
@andrebrait andrebrait deleted the keyboard/improve_andrebrait_keymap branch August 23, 2021 07:54
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants