Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up rgbkb/mun #13801

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Tidy up rgbkb/mun #13801

merged 2 commits into from
Aug 4, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 30, 2021 •
edited
Loading

Description

  • Remove via from default keymap
  • Avoid duplication of matrix code while keeping portscan
  • Remove unused HAL enables

@XScorpion2 If you could have a look over the changes, that would be awesome.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team July 30, 2021 22:51
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 30, 2021
zvecr
zvecr commented Jul 30, 2021
View reviewed changes
keyboards/rgbkb/mun/mcuconf.h Outdated Show resolved Hide resolved
XScorpion2
XScorpion2 approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@XScorpion2 XScorpion2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@XScorpion2
Copy link
Contributor

Please do not merge this until I can test the code changes locally this weekend, especially with the up coming develop > master merge.

@zvecr
Copy link
Member Author

zvecr commented Aug 4, 2021 •
edited
Loading

especially with the up coming develop > master merge.

It is for that reason that this should be merged, as its target is to tidy up the keyboard before it is merged to master and slightly more "locked in". We still accept bug fixes to develop, so anything that might have broken can still be fixed.

@zvecr zvecr merged commit bdaea25 into qmk:develop Aug 4, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
Tidy up rgbkb/mun (qmk#13801)
047d972 
* Tidy up rgbkb/mun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XScorpion2 XScorpion2 XScorpion2 approved these changes

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @XScorpion2 @drashna @tzarc