Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haptic: driver-> feature #13713

Merged
merged 6 commits into from
Jul 26, 2021
Merged

Haptic: driver-> feature #13713

merged 6 commits into from
Jul 26, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 26, 2021 •
edited
Loading

Description

Mostly just relocating some of the non driver logic before a 2nd round of refactoring.

Also reduced some logic to save slightly over 350 bytes.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 26, 2021
@zvecr zvecr marked this pull request as ready for review July 26, 2021 01:50
@zvecr zvecr requested a review from a team July 26, 2021 01:50
@fauxpark fauxpark requested a review from a team July 26, 2021 01:57
drashna
drashna approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm that it doesn't break haptic feedback, too.

@drashna drashna merged commit f945c35 into qmk:develop Jul 26, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
Haptic: driver-> feature (qmk#13713)
e65ba0e
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Haptic: driver-> feature (qmk#13713)
d310bad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark