Port new_keyboard.sh to CLI #13706
Merged
Port new_keyboard.sh to CLI #13706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth noting that i also have a new keyboard subcommand PR (#12795) that takes things in a slightly more "data driven" direction |
Erovia
requested changes
Jul 26, 2021
Erovia
approved these changes
Jul 30, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
Co-authored-by: Erovia <[email protected]>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Co-authored-by: Erovia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the most part this is pretty much just a straight port from the shell script, but with some notable improvements such as validation of keyboard name and type.
Currently there is a bug with MILC's
choice()that causes a default selection of 0 to be interpreted as no default: clueboard/milc#40Types of Changes
Issues Fixed or Closed by This PR
Checklist