Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] Fix meira compliation #13695

Merged
merged 1 commit into from
Jul 25, 2021
Merged

[develop] Fix meira compliation #13695

merged 1 commit into from
Jul 25, 2021

Conversation

daskygit
Copy link
Member

Description

It's hardcoded to only scan 4 columns, so implemented a new define.

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc merged commit a938c54 into qmk:develop Jul 25, 2021
@daskygit daskygit deleted the fix/meira branch August 2, 2021 22:52
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@daskygit @nhongooi
dirty fix (qmk#13695)
b192afc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daskygit @drashna @tzarc