Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dactyl Manuform cleanup #13686

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Dactyl Manuform cleanup #13686

merged 2 commits into from
Jul 27, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 24, 2021 •
edited
Loading

Description

Removed the top level rules.mk - split it out into each subfolder. On its own it's not a buildable keyboard:

☒ handwired/dactyl_manuform: No LAYOUTs defined! Need at least one layout defined in the keyboard.h or info.json.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added bug enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 24, 2021
@fauxpark fauxpark requested a review from a team July 24, 2021 17:23
@fauxpark
Copy link
Member Author

Lint check failed due to missing readmes. All is well.

@drashna drashna requested a review from a team July 25, 2021 02:12
@fauxpark fauxpark linked an issue Jul 25, 2021 that may be closed by this pull request
Tracking issue for qmk info errors #10792
Closed
@fauxpark fauxpark merged commit 468f705 into qmk:develop Jul 27, 2021
@fauxpark fauxpark deleted the dactyl-manuform-cleanup branch July 27, 2021 12:00
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
Dactyl Manuform cleanup (qmk#13686)
6a02287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for qmk info errors
2 participants
@fauxpark @drashna