Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MATRIX_COLS for aeboards/constellation/rev2 #13633

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

fauxpark
Copy link
Member

Description

@Xelus22

☒ aeboards/constellation/rev2: MATRIX_COLS is inconsistent with the size of MATRIX_COL_PINS: 15 != 14

(oddly this value seems to be correct in master, no idea why it hasn't synced)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team July 21, 2021 18:22
@zvecr zvecr merged commit 78265ea into qmk:develop Jul 21, 2021
@fauxpark fauxpark deleted the constellation-rev2-matrix-cols branch July 21, 2021 18:26
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants