Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Six Pack and ortho_ layout updates #13587

Merged
merged 16 commits into from
Jul 20, 2021
Merged

Six Pack and ortho_ layout updates #13587

merged 16 commits into from
Jul 20, 2021

Conversation

Suschman
Copy link

Small changes to Six Pack, and improved ortho_2x3 support as i came along.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 18, 2021
fauxpark
fauxpark requested changes Jul 18, 2021
View reviewed changes
keyboards/sixkeyboard/rules.mk Outdated Show resolved Hide resolved
layouts/default/ortho_2x3/info.json Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team July 18, 2021 16:14
@fauxpark
Copy link
Member

Lint errors:

☒ 40percentclub/5x5: Claims to support a community layout that does not exist: ortho_5x5
Already removed in develop, can be ignored
☒ 40percentclub/6lit: Claims to support a community layout that does not exist: ortho_2x6
Needs to be added to layouts/default
☒ Missing keyboards/handwired/stream_cheap/2x3/readme.md
Readme exists in handwired/stream_cheap, can be ignored (the linter is not very smart here)

@Suschman Suschman requested review from fauxpark and removed request for a team July 18, 2021 17:21
fauxpark
fauxpark requested changes Jul 18, 2021
View reviewed changes
layouts/default/ortho_2x6/info.json Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Jul 18, 2021
View reviewed changes
layouts/default/ortho_5x5/info.json Outdated Show resolved Hide resolved
@Suschman Suschman requested a review from fauxpark July 18, 2021 17:40
@Suschman Suschman changed the title Six Pack and ortho_2x3 layout updates Six Pack and ortho_ layout updates Jul 18, 2021
fauxpark
fauxpark requested changes Jul 18, 2021
View reviewed changes
layouts/default/ortho_5x5/info.json Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team July 18, 2021 18:26
@drashna
Copy link
Member

drashna commented Jul 20, 2021

Thanks!

@drashna drashna merged commit 7e698c7 into qmk:master Jul 20, 2021
@Suschman Suschman deleted the sixpack_and_ortho-2x3_updates branch October 17, 2021 14:30
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Suschman @fauxpark @nhongooi
Six Pack and ortho_ layout updates (qmk#13587)
599b9d8 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Suschman <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Suschman @fauxpark
Six Pack and ortho_ layout updates (qmk#13587)
4a17522 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Suschman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Suschman @fauxpark @drashna