Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Valor Rev 2 #13551

Merged
merged 7 commits into from
Jul 26, 2021
Merged

[Keyboard] Valor Rev 2 #13551

merged 7 commits into from
Jul 26, 2021

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Jul 15, 2021 •
edited
Loading

Description

Add Valor Rev 2
This targets develop as it uses STM32L422

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Add Valor Rev 2

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 15, 2021
drashna
drashna requested changes Jul 20, 2021
View reviewed changes
keyboards/xelus/valor/rev2/rev2.c Outdated Show resolved Hide resolved
@Xelus22 @drashna
remove redundant code
adc0339 
Co-authored-by: Drashna Jaelre <[email protected]>
@drashna drashna requested a review from a team July 20, 2021 05:04
fauxpark
fauxpark requested changes Jul 25, 2021
View reviewed changes
keyboards/xelus/valor/rev2/rules.mk Show resolved Hide resolved
keyboards/xelus/valor/rev2/rules.mk Outdated Show resolved Hide resolved
@Xelus22 Xelus22 requested a review from fauxpark July 25, 2021 08:36
@fauxpark fauxpark requested a review from a team July 25, 2021 11:44
@drashna
Copy link
Member

drashna commented Jul 26, 2021

Thanks!

@drashna drashna merged commit b9902a3 into qmk:develop Jul 26, 2021
@Xelus22 Xelus22 mentioned this pull request Aug 3, 2021
Merged
6 tasks
@Xelus22 Xelus22 deleted the valor_rev2 branch October 18, 2021 16:58
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Xelus22 @drashna
@fauxpark @nhongooi
[Keyboard] Valor Rev 2 (qmk#13551)
505e7c2 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xelus22 @drashna @fauxpark