Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traveller handwired layout macro refactor #13539

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Traveller handwired layout macro refactor #13539

merged 2 commits into from
Jul 14, 2021

Conversation

noroadsleft
Copy link
Member

@noroadsleft noroadsleft commented Jul 13, 2021 •
edited
Loading

Description

Arranges the layout macro and keycodes to physically resemble the keyboard layout, and updates the Configurator rendering (based on the Atreus).

image

cc @milestogo (keyboard maintainer)

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
add mousekey.h include to default keymap
9eea7a8 
Compilation fails with "error: implicit declaration of function 'mousekey_(on|off|send)'" unless this is included... even though `MOUSEKEY_ENABLE = yes`.

*shrugs*
@noroadsleft
physically arrange layout macro
0379d31 
Arrange the layout macro and keycodes to resemble the layout of the assembled board.

Also updates QMK Configurator's layout data.
@noroadsleft noroadsleft requested a review from a team July 13, 2021 16:25
@fauxpark fauxpark requested a review from a team July 13, 2021 16:28
@drashna drashna merged commit dd5ead6 into qmk:master Jul 14, 2021
@noroadsleft noroadsleft deleted the cf/hw_traveller branch July 14, 2021 06:25
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@noroadsleft @nhongooi
Traveller handwired layout macro refactor (qmk#13539)
395386c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark