Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1UP Keyboards 1UP60HTE layout macro touch-up #13529

Merged
merged 7 commits into from
Jul 13, 2021

Conversation

noroadsleft
Copy link
Member

Description

Renames a layout macro to be Community Layouts friendly, and cleans up some file formatting.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

... and enable Community Layout support.
- remove Bootloader selection header comments
- unify Build Options comment header to QMK template
- align inline comments
- convert metadata to list
- add Flashing command
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 12, 2021
@noroadsleft noroadsleft requested a review from a team July 12, 2021 18:23
@noroadsleft noroadsleft merged commit 6b6ee5f into qmk:master Jul 13, 2021
@noroadsleft noroadsleft deleted the cf/1upkeyboards_1up60hte branch July 13, 2021 07:18
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* rename LAYOUT_tsangan to LAYOUT_60_tsangan_hhkb

... and enable Community Layout support.

* use four-space indent and QMK-native keycode aliases

* rules.mk touch-up

- remove Bootloader selection header comments
- unify Build Options comment header to QMK template
- align inline comments

* readme.md touch-up

- convert metadata to list
- add Flashing command

* move layout macro alias to info.json

* apply friendly formatting to info.json

* restore badger keymap to previous (don't edit user keymap)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants