Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Montex add VIA support and keymap. #13488

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Montex add VIA support and keymap. #13488

merged 2 commits into from
Jul 13, 2021

Conversation

mehoron
Copy link
Contributor

@mehoron mehoron commented Jul 8, 2021 •
edited
Loading

  • Fix vendor ID to IDOBAO for Montex.

Description

The vendor ID for the Montex was still the default, I've fixed that as well as added a VIA keymap.

I built out the firmware with a VIA JSON and had it tested, everything works as it should.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ALowery
Add VIA support.
fbd8576 
 * Fix vendor ID.
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 8, 2021
@mehoron mehoron changed the title Add VIA support and keymap. Montex add VIA support and keymap. Jul 8, 2021
drashna
drashna requested changes Jul 11, 2021
View reviewed changes
keyboards/montex/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@mehoron @drashna
Update keyboards/montex/keymaps/via/keymap.c
a438f25 
Add layer suggestion from @drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@drashna drashna requested a review from a team July 11, 2021 16:52
@drashna
Copy link
Member

drashna commented Jul 13, 2021

Thanks!

@drashna drashna merged commit 3cd6cb6 into qmk:master Jul 13, 2021
@mehoron mehoron mentioned this pull request Jul 22, 2021
Merged
6 tasks
@mehoron mehoron deleted the Montex_VIA_Support branch July 22, 2021 15:38
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@mehoron @drashna
@ALowery @nhongooi
[Keyboard] Montex add VIA support and keymap. (qmk#13488)
1ae5d96 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Anthony Lowery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mehoron @drashna @fauxpark @ALowery