-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable g_is31_leds PROGMEM for RGB Matrix IS31FL3737 driver #13480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any boards using the 3737 will need to be updated in this PR.
agreed. a #define flag coukd be added to make configurable but this adds complexity. |
Looks like the |
Awesome, thanks! And verified working on my planck EZ Glow. |
Description
Moves the RGB Matrix g_is31_leds led config array to PROGMEM when using the issi/IS31FL3737 driver.
This array uses ~3bytes per rgb led and this change frees up considerable SRAM for the average rgb matrix keyboard.
Implementing this change to other issi drivers is trivial
This is a Break Change.
Types of Changes
Issues Fixed or Closed by This PR
#13443
*
Checklist