Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable g_is31_leds PROGMEM for RGB Matrix IS31FL3737 driver #13480

Merged
merged 6 commits into from
Jul 12, 2021

Conversation

ccullin
Copy link

@ccullin ccullin commented Jul 7, 2021

Description

Moves the RGB Matrix g_is31_leds led config array to PROGMEM when using the issi/IS31FL3737 driver.
This array uses ~3bytes per rgb led and this change frees up considerable SRAM for the average rgb matrix keyboard.
Implementing this change to other issi drivers is trivial

This is a Break Change.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

#13443
*

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 7, 2021 17:14
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any boards using the 3737 will need to be updated in this PR.

@ccullin
Copy link
Author

ccullin commented Jul 9, 2021

Any boards using the 3737 will need to be updated in this PR.

agreed. a #define flag coukd be added to make configurable but this adds complexity.

@drashna
Copy link
Member

drashna commented Jul 11, 2021

Looks like the mt84, and planck/ez are the only boards in repo that use this controller

@drashna drashna requested a review from a team July 11, 2021 16:40
@ccullin
Copy link
Author

ccullin commented Jul 12, 2021

Looks like the mt84, and planck/ez are the only boards in repo that use this controller

@drashna @fauxpark - I am reading the comment as I need to update the mentioned keyboard files. Please let me know if this is not required and I will blackout them out. (new commit coming).

@drashna
Copy link
Member

drashna commented Jul 12, 2021

Awesome, thanks!

And verified working on my planck EZ Glow.

@drashna drashna merged commit 9c74fd1 into qmk:develop Jul 12, 2021
@zvecr zvecr mentioned this pull request Jul 30, 2021
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants