Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Dip Switch callbacks to boolean functions #13399

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 1, 2021

Description

Like the title says. Changed the callbacks from void, to bool, so that kb level can be overridden.

Types of Changes

  • Core
  • Bugfix
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 1, 2021 06:18
@github-actions github-actions bot added core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support labels Jul 1, 2021
@tzarc tzarc requested a review from a team July 1, 2021 06:43
@drashna drashna merged commit 0bde920 into qmk:develop Jul 1, 2021
@drashna drashna deleted the core/dip_switches branch July 1, 2021 15:22
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 2, 2021
* qmk/develop: (25 commits)
  [Core] Unite half-duplex and full-duplex serial drivers (qmk#13081)
  Add missing Quefrency layouts for QMK Configurator (qmk#13384)
  [Keyboard] Adding Via support to the GON NerD60 (qmk#13395)
  [Keymap] Add haervig userspace and keymaps (qmk#13362)
  Convert Dip Switch callbacks to boolean functions (qmk#13399)
  Changed Yeehaw Default Keymap (qmk#13341)
  [Docs] update Japanese translation of other_eclipse.md (qmk#12776)
  update Japanese translation of config_options.md (qmk#12695)
  Translated 'feature_advanced_keycodes.md'. (qmk#12454)
  [Docs] Japanese translation of docs/keycodes_basic.md (qmk#11044)
  Illusion Rosa: correct layout macro names (qmk#13387)
  FJLabs Midway60: physically arrange layout macro and fix info.json data (qmk#13386)
  Sanctified Dystopia: physically arrange layout macro (qmk#13385)
  Updates for keymap: ut472/stefanopace (qmk#13370)
  [Keyboard] update debounce time on kint boards (qmk#13351)
  [Keymap] RGB Timeout added to userspace (qmk#13339)
  [Keyboard][Bug] Fix LED indicators on Skeletn87 (qmk#13335)
  [Keyboard] Pteron36, open source 3x5_3 supporting layout (qmk#13313)
  Drashna's split updates (qmk#13350)
  [Keymap] Create bingocaller keymap for DZ60RGB-ANSI (qmk#13311)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants