Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmmk/pro/mike1808 keymap #13398

Merged
merged 6 commits into from
Aug 17, 2021
Merged

gmmk/pro/mike1808 keymap #13398

merged 6 commits into from
Aug 17, 2021

Conversation

mike1808
Copy link

@mike1808 mike1808 commented Jul 1, 2021

Description

Add my keymap for gmmk/pro

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the keymap label Jul 1, 2021
@mike1808 mike1808 changed the title Gmmk pro keymap gmmk/pro/mike1808 keymap Jul 1, 2021
@ach5948
Copy link

ach5948 commented Jul 1, 2021

The RGB Matrix LEDMap is a really cool idea!

@cj360
Copy link

cj360 commented Jul 5, 2021

The Ledmap is awesome though I'm at a loss as to why its setting the rgb to white on function layer when I attempt to copy it.

@mike1808
Copy link
Author

mike1808 commented Jul 6, 2021

hey @cj360 can you tell me your content of rules.mk?

@cj360
Copy link

cj360 commented Jul 6, 2021

Sure thing here's a gist.

@mike1808
Copy link
Author

mike1808 commented Jul 6, 2021

@cj360 looks fine. I'm curious, why it can set rgb to white. I don't have any code setting it to white. Can you try to run qmk clean before compiling it? Also, maybe you have conflicting RGB code in rgb_matrix_indicators_advanced_user

@drashna drashna requested a review from a team July 6, 2021 22:07
@ForsakenRei
Copy link
Contributor

The LED matrix is really a cool idea, which will make customized LEDs for layers way easier.
If I want to use it with my existing keymap.c, except the LED layout I need to copy to my keymap.c and the rules.mk I need change, which files will be essential to have the LED layout functionable?

@mike1808
Copy link
Author

mike1808 commented Jul 27, 2021

@ForsakenRei that was my initial implementation, but it was consuming a lot of memory. The current implementation requires you to define a macro mapping each key to RGB index in g_led_config.

@ForsakenRei
Copy link
Contributor

@ForsakenRei that was my initial implementation, but it was consuming a lot of memory. The current implementation requires you to define a macro mapping each key to RGB index in g_led_config.

I see. Thanks for the tip, I will give it a try.

@tzarc tzarc merged commit 8577167 into qmk:develop Aug 17, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* Add gmmk/pro/mike1808 keymap

* Add licenses

* Update readme

* Add underglow support for rgb matrix layers

* Change FN to TT

* Fix rgb layer disabling during rgb settings change

* also clean up some code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants