Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate RGB/HSV color defs to a more fitting place #13377

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Relocate RGB/HSV color defs to a more fitting place #13377

merged 1 commit into from
Jun 29, 2021

Conversation

fauxpark
Copy link
Member

Description

Allows for rgblight_list.h to eventually be removed.

Both rgb_matrix.h and rgblight.h include color.h, and are included by quantum.h, so these defines should still be visible to keymaps.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 29, 2021 03:03
drashna
drashna approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo, I like this, a lot!

@drashna drashna requested a review from a team June 29, 2021 03:37
@zvecr zvecr merged commit 6530822 into qmk:develop Jun 29, 2021
@fauxpark fauxpark deleted the colors-relocate branch June 29, 2021 22:07
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
Relocate RGB/HSV color defs to a more fitting place (qmk#13377)
79f4190
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
Relocate RGB/HSV color defs to a more fitting place (qmk#13377)
26bcec4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr