Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RGBLight code into its own folder #13312

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Conversation

fauxpark
Copy link
Member

Description

More tidying up of quantum/.

@MxBlu The changes to the mxss rules.mk results in a different MD5, but the firmware size is exactly the same, and it appears the only difference is in the order of compilation (and thus linkage) of a couple of files so I don't think I've broken anything.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@MxBlu
Copy link
Contributor

MxBlu commented Jun 23, 2021

Likely fine, I'll test it out (and apologies again for the maintainance task, I'll put an effort into getting rid of the localised ver of rgblight.c in the coming months hopefully)

@fauxpark fauxpark merged commit cb23fe9 into qmk:develop Jun 28, 2021
@fauxpark fauxpark deleted the rgblight-reorg branch June 28, 2021 05:15
@fauxpark fauxpark mentioned this pull request Jun 28, 2021
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants