Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGB Matrix eeprom write limiting #13238

Merged
merged 4 commits into from
Jun 20, 2021
Merged

RGB Matrix eeprom write limiting #13238

merged 4 commits into from
Jun 20, 2021

Conversation

XScorpion2
Copy link
Contributor

Description

Adds a limiter to updating the eeprom for rgb matrix to once every full rgb matrix loop. This helps reduce lagging / frequent writes due to rapid controlling of the rgb keycodes via encoders or such.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 18, 2021
@drashna
Copy link
Member

drashna commented Jun 19, 2021

Could this be added to led_matrix as well, to keep parity?
(also should probably do similar with rgb light, but not here)

@XScorpion2
Copy link
Contributor Author

Could this be added to led_matrix as well, to keep parity?
(also should probably do similar with rgb light, but not here)

done (led matrix)

@drashna drashna requested a review from a team June 19, 2021 15:14
@drashna drashna merged commit 5b7cf9f into qmk:develop Jun 20, 2021
@XScorpion2 XScorpion2 deleted the feature/rgb_matrix_eeprom_limits branch June 24, 2021 14:26
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@XScorpion2 @nhongooi
RGB Matrix eeprom write limiting (qmk#13238)
db318c6
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@XScorpion2
RGB Matrix eeprom write limiting (qmk#13238)
d8c3dc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XScorpion2 @drashna @fauxpark