Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOCC keyboard "config.h" had the incorrect amount of LEDs listed. Original code listed 16 rather than 20. #13175

Merged
merged 1 commit into from
Jul 20, 2021
Merged

BOCC keyboard "config.h" had the incorrect amount of LEDs listed. Original code listed 16 rather than 20. #13175

merged 1 commit into from
Jul 20, 2021

Conversation

wamsleymj
Copy link
Contributor

Description

BOCC keyboard "config.h" had the incorrect amount of LEDs listed. Original code listed 16 rather than 20.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Evidence from Discord about the issue:
Screen Shot 2021-06-10 at 2 22 08 PM
Screen Shot 2021-06-10 at 2 22 26 PM

Successful make output:
bocc_success_make_output.txt

BOCC Keyboard - Keyboard is starting to ship. There is an error in th…
e570332 
…e config that incorrectly list 16 LEDs rather than the 20 it has.
@wamsleymj
Copy link
Contributor Author

@drashna - Thanks for taking a look!

@wamsleymj
Copy link
Contributor Author

So this is approved, but when will it get merged?

@drashna drashna requested a review from a team July 20, 2021 04:02
@drashna
Copy link
Member

drashna commented Jul 20, 2021

So this is approved, but when will it get merged?

Usually, we want 2 approvals before it gets merged.

@drashna
Copy link
Member

drashna commented Jul 20, 2021

Thanks!

@drashna drashna merged commit 35ee990 into qmk:master Jul 20, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@wamsleymj @nhongooi
[Keyboard] fix LED issue BOCC keyboard (qmk#13175)
f0a28e2 
Co-authored-by: Michael Wamsley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wamsleymj @drashna @fauxpark