Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Creator Pro by SergioPoverony #13154

Merged
merged 24 commits into from
Jul 3, 2021
Merged

[Keyboard] Add Creator Pro by SergioPoverony #13154

merged 24 commits into from
Jul 3, 2021

Conversation

sergiopoverony
Copy link

@sergiopoverony sergiopoverony commented Jun 9, 2021 •
edited
Loading

Description

This is keyboard for support making video content.
Have 8 button and 1 encoder with one button? summary 9 button and Encoder
via layout prepared, but need pull keyboard here

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 9, 2021
@tzarc
Copy link
Member

tzarc commented Jun 15, 2021

Can you explain why you're using 0x20A0 as the VID, which is currently assigned to Clay Logic?

@sergiopoverony
Copy link
Author

Can you explain why you're using 0x20A0 as the VID, which is currently assigned to Clay Logic?

Yes, mistake vusb vid pid cant use in usb. Changed all

@sergiopoverony
Update readme.md
e1ff2c7 
Add real photo
@sergiopoverony sergiopoverony changed the base branch from develop to master June 30, 2021 18:48
@sergiopoverony sergiopoverony changed the base branch from master to develop June 30, 2021 18:49
@sergiopoverony
Copy link
Author

Please pull to Master

@Erovia Erovia requested a review from a team June 30, 2021 18:59
fauxpark
fauxpark requested changes Jul 1, 2021
View reviewed changes
keyboards/sergiopoverony/creator_pro/readme.md Outdated Show resolved Hide resolved
keyboards/sergiopoverony/creator_pro/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team July 1, 2021 10:47
@drashna
Copy link
Member

drashna commented Jul 3, 2021

Thanks!

@drashna drashna merged commit ca4536e into qmk:develop Jul 3, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@sergiopoverony @fauxpark
@drashna @nhongooi
[Keyboard] Add Creator Pro by SergioPoverony (qmk#13154)
c1d1ea9 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergiopoverony @tzarc @drashna @fauxpark