Updated encoder_update_user on my keymap to follow the new signature on quantum #13152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Jun 9, 2021
fauxpark
approved these changes
Jun 9, 2021
|
Thanks! |
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jul 30, 2021
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jul 30, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
void encoder_update_user(int8_t index, bool clockwise)tobool encoder_update_user(uint8_t index, bool clockwise).Also swapped the
KC_GRVand theKC_MINSaround.Types of Changes
Issues Fixed or Closed by This PR
Checklist