Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GMMK Pro RGB Support #13147

Merged
merged 21 commits into from
Jun 10, 2021
Merged

GMMK Pro RGB Support #13147

merged 21 commits into from
Jun 10, 2021

Conversation

Gigahawk
Copy link

@Gigahawk Gigahawk commented Jun 9, 2021

Description

Add support for AW20216 RGB controller, enable RGB Matrix for GMMK Pro

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna reviewed Jun 9, 2021
View reviewed changes
keyboards/gmmk/pro/pro.c Outdated Show resolved Hide resolved
drashna
drashna requested changes Jun 9, 2021
View reviewed changes
drivers/awinic/aw20216.h Show resolved Hide resolved
drivers/awinic/aw20216.h Outdated Show resolved Hide resolved
drivers/awinic/aw20216.h Outdated Show resolved Hide resolved
@Gigahawk Gigahawk requested a review from drashna June 9, 2021 08:48
@drashna drashna requested a review from a team June 10, 2021 00:14
@Gigahawk
Copy link
Author

@drashna would you like me to rebase and squash?

@tzarc
Copy link
Member

tzarc commented Jun 10, 2021

@drashna would you like me to rebase and squash?

Entirely up to you, we'll end up doing so before merging regardless, so as long as there aren't any conflicts, should be fine to leave as-is.

@tzarc tzarc merged commit 32b2ac0 into qmk:develop Jun 10, 2021
SirBubbls pushed a commit to SirBubbls/qmk_firmware that referenced this pull request Jun 11, 2021
@Gigahawk @drashna @SirBubbls
GMMK Pro RGB Support (qmk#13147)
b3f1d6c 
* Enable SPI1 for GMMK pro

* Setup initial boilerplate for new LED driver

* RGB matrix minimally functional

* Map full LED matrix

* Return keymap to default

* Fix printscreen LED mapping

* Reduce max brightness

* Default values for AW20216

* Add documentation for AW20216

* Disable console and warnings

* Run cformat

* Update drivers/awinic/aw20216.h

Co-authored-by: Drashna Jaelre <[email protected]>

* make aw struct match issi struct

Co-authored-by: Drashna Jaelre <[email protected]>

* add led location defines

Co-authored-by: Drashna Jaelre <[email protected]>

* Use led pin definitions in keyboard.c

* Add driver indices to led map

* Fix elif typo

* Run cformat

* Update docs

* Fix typo in docs

* Document global brightness limits

Co-authored-by: Drashna Jaelre <[email protected]>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
@Gigahawk @drashna @mechlovin
GMMK Pro RGB Support (qmk#13147)
869102c 
* Enable SPI1 for GMMK pro

* Setup initial boilerplate for new LED driver

* RGB matrix minimally functional

* Map full LED matrix

* Return keymap to default

* Fix printscreen LED mapping

* Reduce max brightness

* Default values for AW20216

* Add documentation for AW20216

* Disable console and warnings

* Run cformat

* Update drivers/awinic/aw20216.h

Co-authored-by: Drashna Jaelre <[email protected]>

* make aw struct match issi struct

Co-authored-by: Drashna Jaelre <[email protected]>

* add led location defines

Co-authored-by: Drashna Jaelre <[email protected]>

* Use led pin definitions in keyboard.c

* Add driver indices to led map

* Fix elif typo

* Run cformat

* Update docs

* Fix typo in docs

* Document global brightness limits

Co-authored-by: Drashna Jaelre <[email protected]>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
@Gigahawk @drashna @mechlovin
GMMK Pro RGB Support (qmk#13147)
1d9dcb5 
* Enable SPI1 for GMMK pro

* Setup initial boilerplate for new LED driver

* RGB matrix minimally functional

* Map full LED matrix

* Return keymap to default

* Fix printscreen LED mapping

* Reduce max brightness

* Default values for AW20216

* Add documentation for AW20216

* Disable console and warnings

* Run cformat

* Update drivers/awinic/aw20216.h

Co-authored-by: Drashna Jaelre <[email protected]>

* make aw struct match issi struct

Co-authored-by: Drashna Jaelre <[email protected]>

* add led location defines

Co-authored-by: Drashna Jaelre <[email protected]>

* Use led pin definitions in keyboard.c

* Add driver indices to led map

* Fix elif typo

* Run cformat

* Update docs

* Fix typo in docs

* Document global brightness limits

Co-authored-by: Drashna Jaelre <[email protected]>
Sayt123 pushed a commit to Sayt123/PersonalKeyboardLayouts that referenced this pull request Sep 9, 2021
Rebinding
dee9ce1 
Rebound keys on the GMMK Pro to reflect the added RGB functionality of qmk/qmk_firmware#13147 I really shoulda looked around more at first lol.
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Gigahawk @drashna @nhongooi
GMMK Pro RGB Support (qmk#13147)
acf265b 
* Enable SPI1 for GMMK pro

* Setup initial boilerplate for new LED driver

* RGB matrix minimally functional

* Map full LED matrix

* Return keymap to default

* Fix printscreen LED mapping

* Reduce max brightness

* Default values for AW20216

* Add documentation for AW20216

* Disable console and warnings

* Run cformat

* Update drivers/awinic/aw20216.h

Co-authored-by: Drashna Jaelre <[email protected]>

* make aw struct match issi struct

Co-authored-by: Drashna Jaelre <[email protected]>

* add led location defines

Co-authored-by: Drashna Jaelre <[email protected]>

* Use led pin definitions in keyboard.c

* Add driver indices to led map

* Fix elif typo

* Run cformat

* Update docs

* Fix typo in docs

* Document global brightness limits

Co-authored-by: Drashna Jaelre <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Gigahawk @drashna
GMMK Pro RGB Support (qmk#13147)
926e959 
* Enable SPI1 for GMMK pro

* Setup initial boilerplate for new LED driver

* RGB matrix minimally functional

* Map full LED matrix

* Return keymap to default

* Fix printscreen LED mapping

* Reduce max brightness

* Default values for AW20216

* Add documentation for AW20216

* Disable console and warnings

* Run cformat

* Update drivers/awinic/aw20216.h

Co-authored-by: Drashna Jaelre <[email protected]>

* make aw struct match issi struct

Co-authored-by: Drashna Jaelre <[email protected]>

* add led location defines

Co-authored-by: Drashna Jaelre <[email protected]>

* Use led pin definitions in keyboard.c

* Add driver indices to led map

* Fix elif typo

* Run cformat

* Update docs

* Fix typo in docs

* Document global brightness limits

Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gigahawk @tzarc @drashna